Skip to content

Commit

Permalink
Fix Hypercore PR approval
Browse files Browse the repository at this point in the history
Team agreed that changes to Hypercore table access method files only
require a single approver for the time being. This might be revised in
the future.
  • Loading branch information
mkindahl committed Nov 26, 2024
1 parent 14c2c1d commit 67bcd2e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/pr-approvals.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ jobs:
# Get the list of modified files in this pull request
echo "Modified files: "
gh pr view $PR_NUMBER --json files
files=$(gh pr view $PR_NUMBER --json files --jq '.files.[].path | select(startswith(".github") | not)')
# Get modified files, but exclude those that are workflow
# files or are related to Hypercore table access
# method. These require only a single reviewer.
files=$(gh pr view $PR_NUMBER --json files --jq '.files.[].path | select(startswith(".github") or test("hypercore|columnar_scan") | not)')
# Get the number of approvals in this pull request
echo "Reviews: "
Expand Down

0 comments on commit 67bcd2e

Please sign in to comment.