Fix links to jonatas.github.io/timescaledb #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
force-pushed
the
mpeveler/fix-docs-images
branch
from
53321c8 to
97f91c3
Compare
MasterOdin
commented
Jan 16, 2025
| @@ -1,5 +1,5 @@ | |||
| # ruby candlestick.rb postgres://user:pass@host:port/db_name | |||
| # @see https://jonatas.github.io/timescaledb/candlestick_tutorial | |||
| # @see https://timescale.github.io/timescaledb-ruby/toolkit_candlestick/ | |||
There was a problem hiding this comment.
I wasn't sure if this was correct, as I'm not sure there ever was a documented called candlestick_tutorial in the repo. 🤷
There was a problem hiding this comment.
Yes! it's correct!
Thank you very much! I removed almost all references, but some of the refs in the code are still there!
jonatas
reviewed
Jan 16, 2025
| @@ -23,7 +23,7 @@ In this example, we're going to use the [lttb][3] function, that is part of the | |||
| The image bellow corresponds to the step by step guide provided here. | |||
|
|
|||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Very good! I remember I faced some issues using relative links but let's try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes a couple of links I found to
jonatas.github.io/timescaledbto work with the new repo location. For the three images, I chose to use relative paths asmkdocsseemed to be fine with it locally, and this seemed less brittle in case the repo ever changed names again.