Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POP-7487] Add materialize adapter for dbt 1.0+ #3

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: curl -sSL https://install.python-poetry.org | python3 -

- name: Generate requirements file
run: bash ./bin/generate_requirements.sh ${{ matrix.version }} ${{ matrix.adapter }}
run: python3 ./bin/generate_requirements.py ${{ matrix.version }} ${{ matrix.adapter }}

# snowflake adapter for dbt < 1.1 does not have prebuilt arm64 wheels, and building it
# from source is very ardious and time consuming (due to pyarrow), so only build for
Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ in the lock file).
As part of our CD process, we then handle generating a per adapter requirements file
from these two files.

### Requirements

* Python 3.8+
* [poetry](https://python-poetry.org/)

### Building Images Locally

Docker images can be built locally via the `./bin/build.sh` script, which takes two
Expand Down
2 changes: 1 addition & 1 deletion bin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ BASE_DIR=${SCRIPT_DIR}/..
version=$1
adapter=$2

"${SCRIPT_DIR}"/generate_requirements.sh "${version}" "${adapter}"
python3 "${SCRIPT_DIR}"/generate_requirements.py "${version}" "${adapter}"

if [ -z "${adapter}" ]; then
requirements_file="requirements.txt"
Expand Down
62 changes: 62 additions & 0 deletions bin/generate_requirements.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
#!/usr/bin/env python3

from argparse import ArgumentParser
from pathlib import Path
import shutil
from subprocess import run, STDOUT
from tempfile import TemporaryDirectory

current_dir = Path(__file__).resolve().parent
base_requirements_dir = current_dir.parent / "requirements"

parser = ArgumentParser()
parser.add_argument("version", type=str, help="Version of dbt to generate requirements for")
parser.add_argument("adapter", type=str, help="Adapter to generate requirements for", nargs='?')
args = parser.parse_args()

version = args.version # type: str
adapter = args.adapter # type: str | None

requirements_dir = base_requirements_dir / str(args.version)

if not requirements_dir.exists():
raise SystemExit(f"Version {args.version} not found")

with TemporaryDirectory(prefix="docker-dbt-") as tmpdir:
tmpdir_path = Path(tmpdir)

if adapter is None:
print(f"Building requirements for {version}")
shutil.copy(requirements_dir / "pyproject.toml", tmpdir_path / "pyproject.toml")
requirements_file = "requirements.txt"
else:
contents = (requirements_dir / "pyproject.toml").read_text()
if adapter not in contents:
raise SystemExit(f"Adapter {adapter} for {version} not found")

print(f"Building requirements for {version}/{adapter}")

extra_requirements = []
if adapter == "materialize":
extra_requirements = ["postgres"]

with (requirements_dir / "pyproject.toml").open("r") as f, (tmpdir_path / "pyproject.toml").open("w") as g:
for line in f:
if not line.startswith('dbt-') or any(val in line for val in ['core', 'rpc', adapter] + extra_requirements):
g.write(line)

requirements_file = f"requirements-{adapter}.txt"

shutil.copy(requirements_dir / "poetry.lock", tmpdir_path / "poetry.lock")
print("Updating poetry.lock file")
result = run(["poetry", "-q", "lock"], cwd=tmpdir_path)
if result.returncode != 0:
print(result.stdout.decode("utf-8"))
print(result.stderr.decode("utf-8"))
raise SystemExit("Failed to update poetry.lock file")
print("Exporting requirements file")
result = run(["poetry", "export", "-o", f"{requirements_dir / requirements_file}"], cwd=tmpdir_path)
if result.returncode != 0:
print(result.stdout.decode("utf-8"))
print(result.stderr.decode("utf-8"))
raise SystemExit("Failed to export requirements file")
55 changes: 0 additions & 55 deletions bin/generate_requirements.sh

This file was deleted.

Loading