Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

[Feature] 'currentSticky' && OnStickHeaderChanged() #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Feature] 'currentSticky' && OnStickHeaderChanged() #127

wants to merge 2 commits into from

Conversation

android-feng
Copy link

@android-feng android-feng commented Jun 24, 2016

Hi there:

Thanks for this great lib. It really helped us a lot during ur work. And these two more features below are some functions I guess might be useful to other developers who also like to use it during daily work. So, sorry for bothering and please review 😄

Reason:

  1. [currentSticky] the position value OnHeaderClickListener returned is not correct when the header view is sticky, it always returns 1. Thus, I guess a way out is adding this 'currentSticky' to Listener's callback. And then when sticky, we can just use recyclerview LayoutManager's findFirstVisibleItemPosition()first item to do this hack.
  2. OnStickHeaderChanged() could be used to change Stick Header's details when header changed

@timehop-deploy @jacobtabak @emanuelet Plz Review 😄

@android-feng android-feng changed the title [Feature]1. Add boolean 'currentSticky' in OnHeaderClickListener's callback ; 2. Add OnStickHeaderChanged() Listener [Feature]1. Add boolean 'currentSticky' in OnHeaderClickListener's callback; 2. Add OnStickHeaderChanged() Listener Jun 24, 2016
@android-feng android-feng changed the title [Feature]1. Add boolean 'currentSticky' in OnHeaderClickListener's callback; 2. Add OnStickHeaderChanged() Listener [Feature]1. add boolean 'currentSticky' in OnHeaderClickListener's callback; 2. Add OnStickHeaderChanged() Listener Jun 24, 2016
@android-feng android-feng changed the title [Feature]1. add boolean 'currentSticky' in OnHeaderClickListener's callback; 2. Add OnStickHeaderChanged() Listener [Feature]1. add boolean 'currentSticky' in OnHeaderClickListener; 2. Add OnStickHeaderChanged() Listener Jun 24, 2016
@android-feng android-feng changed the title [Feature]1. add boolean 'currentSticky' in OnHeaderClickListener; 2. Add OnStickHeaderChanged() Listener [Feature]1. add boolean 'currentSticky'; 2. Add OnStickHeaderChanged() Listener Jun 24, 2016
@android-feng android-feng changed the title [Feature]1. add boolean 'currentSticky'; 2. Add OnStickHeaderChanged() Listener [Feature] boolean 'currentSticky'; && OnStickHeaderChanged() Listener Jun 24, 2016
@android-feng android-feng changed the title [Feature] boolean 'currentSticky'; && OnStickHeaderChanged() Listener [Feature] 'currentSticky' && OnStickHeaderChanged() Jun 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant