-
-
Notifications
You must be signed in to change notification settings - Fork 282
Hack around a getting precise time in Windows #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ec76f8
to
59ae91d
Compare
A few things:
|
|
I'm still not quite sure this is worthy of another release. As I mentioned, 0.1 isn't supported any more. The current limitation of ~10ms is how it's been for a very long time. If this is released in a 0.1.43, there are a number of other things that I have previously closed that people would want to revisit. Is there anywhere this has caused major issues that can't be worked around? |
I guess that a possible workaround is to bake this functionality straight into the |
As I decided in #240, I'll be creating one final release for 0.1 at some point in the future. As such, I'll review this PR along with others when I get the chance. |
It would be nice to have a test plan for these older versions of Windows, both with stable rust and 1.21 (if possible). |
This pull request has not had any activity recently. It will be closed without further activity. |
This takes the approach from rust-lang/rust#67266 by @dbergman. This may be necessary for the v0.1 branch of
time
because the widely-usedchrono
crate still depends on it. When writing logs on Windows, crates such assimplelog
which depend onchrono
would benefit from a better timestamp. @quodlibetor @Drakulix