Ensure we can delete branches fast in the dashboard #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to enable e.g. `ddd` to delete three branches in a row. Hence
we must stay on the main thread ("sync" or blocking) so that after the
deletion, first the view updates and only then the next key press is
processed.
Note that we have similar problem in the status view where we call
`interface.refresh_repo_status_and_render()` to have a blocking update,
which is more elegant and self-contained. That is not done easily here
as we call out to a command `gs_delete_branch` which is commonly used.
To make this command parametric just to change its final side-effect
`util.view.refresh_gitsavvy_interfaces(self.window)` seems more work
and might not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable e.g.
dddto delete three branches in a row. Hence we must stay on the main thread ("sync" or blocking) so that after the deletion, first the view updates and only then the next key press is processed.Note that we have similar problem in the status view where we call
interface.refresh_repo_status_and_render()to have a blocking update, which is more elegant and self-contained. That is not done easily here as we call out to a commandgs_delete_branchwhich is commonly used. To make this command parametric just to change its final side-effectutil.view.refresh_gitsavvy_interfaces(self.window)seems more work and might not worth it.Truly a technical debt PR.