Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize branch dashboard syntax #1834

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Normalize branch dashboard syntax #1834

merged 1 commit into from
Dec 8, 2023

Conversation

kaste
Copy link
Collaborator

@kaste kaste commented Dec 8, 2023

  • Mark the sha's as constant.other... just like in the other dashboards.

  • Mark the active branch indicator as punctuation....

  • Mark the whole line of the active branch using a meta...active-branch scope.

  • Do not use string.other... at all. Esp. do not mark the active branch's name as such. User can target that name with e.g.

    meta.git-savvy.branches.branch.active-branch meta.git-savvy.branches.branch.name

- Mark the sha's as `constant.other...` just like in the other
  dashboards.

- Mark the active branch indicator as `punctuation...`.

- Mark the whole line of the active branch using a
  `meta...active-branch` scope.

- Do not use `string.other...` at all.  Esp. do not mark the active
  branch's name as such.  User can target that name with e.g.

  ```
  	  meta.git-savvy.branches.branch.active-branch
  	  meta.git-savvy.branches.branch.name
  ```
@kaste kaste enabled auto-merge December 8, 2023 23:15
@kaste kaste merged commit 4f4cd5b into master Dec 8, 2023
8 checks passed
@kaste kaste deleted the normalize-branch-syntax branch December 8, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant