Pass starting point as initial prompt text when creating new branches #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike with remote branches, local branches that were the target of the `[b]` shortcut, were failing to pass the branch name as the initial text of the prompt for the new branch. This commit was already in #1797 which got reverted in #1800 because it threw. Since then we taught `base_commands.WithInputHandlers` to include arguments with their default values if the command was not called with them, essentially fixing the underlying issue. Still, Pavel's patch needed an `or = ""` because the default `start_point` is `None` which is not an allowed initial text for an input handler. Added that. Signed-off-by: herr kaste <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike with remote branches, local branches that were the target of the
[b]shortcut, were failing to pass the branch name as the initial text of the prompt for the new branch.This commit was already in #1797 which got reverted in #1800 because it threw. Since then we taught
base_commands.WithInputHandlersto include arguments with their default values if the command was not called with them, essentially fixing the underlying issue.Still, Pavel's patch needed an
or = ""because the defaultstart_pointisNonewhich is not an allowed initial text for an input handler. Added that.