fix the setting issue, add missed field

tim-hub · Dec 16, 2022 · 7abe319 · 7abe319
1 parent 8dd061b
commit 7abe319
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/VerseSuggesting.ts b/src/VerseSuggesting.ts
@@ -28,9 +28,9 @@ export class VerseSuggesting implements IVerseSuggesting {
   public get ReplacementContent(): string {
     let head = `> [!Bible]`;
     let bottom = '';
-    if (this.settings.collapsibleVerses==true){
+    if (this.settings?.collapsibleVerses){
       head += '-';
-    }   
+    }
     head += ' ';
 
     if (this.settings.referenceLinkPosition === BibleVerseReferenceLinkPosition.Header || this.settings.referenceLinkPosition ===  BibleVerseReferenceLinkPosition.AllAbove ) {

diff --git a/src/data/constants.ts b/src/data/constants.ts
@@ -11,9 +11,11 @@ export const APP_NAMING = {
 export interface BibleReferencePluginSettings {
   bibleVersion: string;
   referenceLinkPosition?: BibleVerseReferenceLinkPosition;
+  collapsibleVerses?: boolean;
 }
 
 export const DEFAULT_SETTINGS: BibleReferencePluginSettings = {
   bibleVersion: BibleVersionCollection[0].key,
   referenceLinkPosition: BibleVerseReferenceLinkPosition.Header,
+  collapsibleVerses: false,
 }
diff --git a/src/ui/BibleReferenceSettingTab.ts b/src/ui/BibleReferenceSettingTab.ts
@@ -78,7 +78,7 @@ export class BibleReferenceSettingTab extends PluginSettingTab {
     new Setting(containerEl)
       .setName('Make Verses Collapsible')
       .setDesc('Make the inserted verses collapsible')
-      .addToggle(toggle => toggle.setValue(this.plugin.settings.collapsibleVerses)
+      .addToggle(toggle => toggle.setValue(!!this.plugin.settings?.collapsibleVerses)
       .onChange((value) => {
         this.plugin.settings.collapsibleVerses = value;
         this.plugin.saveData(this.plugin.settings);