Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Incorporate shader fixes from SSE Engine Fixes #763

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MostExcellent
Copy link
Contributor

@MostExcellent MostExcellent commented Jan 31, 2025

Includes two fixes from SSE Engine fixes:

  1. BSLightingShaderForceAlphaTest: Forces alpha testing for BSLightingShader when appropriate, excluding specific techniques (eye, environment mapping, and parallax variants). Fixes object LOD reflections on water.
  2. BSLightingShaderParallaxBug: Fixes eye vector updates for parallax shading techniques by forcing updates when the parallax technique is detected. It is required for parallax meshes that don't have specular enabled to work properly.

@MostExcellent
Copy link
Contributor Author

I've tested it and it seems to work. I installed additional parallax meshes for testing as well as community shaders and complex materials, and no parallax bug was found when running with the build of skyrim together that incorporated the fix. Alternatively I could look into broader compatibility between STR and engine fixes (forking engine fixes?), depending on which hook(s) is the problem, although I'm assuming it's more complicated than I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant