constellation-refactor #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…such as missing annotations, lower-case static variables and diamond interfaces 🎨 removed duplicate assets - Lato-Bold-14.vlw, Lato-Regular-11.vlw and unfolding-mini-icon.png ✅ ensured all examples and tests run (note: several of the tests currently do not work due to broken references to map services or files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am doing some work on Constellation (https://github.com/constellation-app/constellation), which uses Unfolding Maps to visualise geospatial information. I have made several improvements on top of Unfolding Maps inside Constellation (such as more flexible feature and marker handling, and a map overlay and layer framework) which I would like to share back to this project. I am also interested in making further improvements (such as customisable map controls) which cannot simply be applied on top, and will instead require changes to this project.
This pull request is just in preparation of all that, and only consists of code style and quality improvements... so that any changes I do make start from a consistent baseline. There are a lot of changes here, so i'm happy to take it slow and talk through my changes in detail if you need.
To start with - there are two commits in this pull request:
64c6478: I used Netbeans built in auto-formatter to normalise the format of all code.
b08991c: I performed a manual pass over all code to fix any remaining style issues I could find, as well as to make sure all the examples and tests worked (where possible).