Add FORCE_SSE compile option #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/work-in-progress
v01dstar
force-pushed
the
compile-option
branch
from
7f31361 to
4b9dd64
Compare
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
compile-option
branch
from
4b9dd64 to
a7b1b76
Compare
ti-chi-bot
bot
added
size/M
|
/run-all-tests |
|
/test |
|
@glorv: No presubmit jobs available for tikv/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
LykxSassinator
approved these changes
Oct 8, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
overvenus
approved these changes
Oct 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LykxSassinator, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
v01dstar
added a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Yang Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FORCE_SSEhas been deprecated in RocksDB upstream. It recommends usingPORTABLE=min_cpu_archto turn on the compiling optimizations. e.g.PORTABLE=haswell, which will then propagate to the compiler option-march=haswelland then turn on SSE.However, I guess TiKV can't assume CPU arch. So the best option for TiKV woud be
PORTABLE=x86-64-v2. While, current PingCAP CI's gcc version does not supportx86-64-v2yet. For now, we can just add thatFORCE_SSEback.Removing
HOMEPAGE_URL https://rocksdb.org/, since it needs CMake > 3.12, while PingCAP CI now only support CMake 3.10