Add support for TiKV flow control #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
dco-signoff: yes
ti-chi-bot
bot
added
the
size/L
Connor1996
approved these changes
Sep 27, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
glorv
approved these changes
Sep 27, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
flow-control
branch
from
9664f5a to
d60ab01
Compare
glorv
approved these changes
Sep 29, 2024
LykxSassinator
approved these changes
Sep 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, glorv, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
Please merge this with #393, next time upgrading RocksDB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing RocksDB's write stall mechanism with TiKV flow control.
This includes:
#251 add disable write stall option
#241 expose ingest level info, so that flow control knows which type of limit to apply. e.g. ingest to 0 is considered a flush, while, ingest to non-zero level is considered a compaction.
base_background_compactionrelated code in #251 is removed, since it has been deprecated in RocksDB