Enrich write batch #379
Merged
Enrich write batch #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
ti-chi-bot
bot
added
needs-1-more-lgtm
LykxSassinator
approved these changes
Sep 27, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
I want to use format of rocksdb::WriteBatch to encode key-value pairs of TiKV, and I need an more effective method to copy data from Entry to WriteBatch directly so that I could avoid CPU cost of decode. Signed-off-by: Little-Wallace <[email protected]> Signed-off-by: tabokie <[email protected]> Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
enrich-write-batch
branch
from
321c3b0 to
4b571c4
Compare
ti-chi-bot
bot
added
size/M
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
LykxSassinator
approved these changes
Sep 27, 2024
glorv
approved these changes
Sep 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, glorv, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #177
Adding
WriteBatch::IteratorandWriteBatchInternal:: AppendContents().WriteBatchInternal::AppendContents()is used by TiKV to efficiently merge multiple write batches into a larger batch, thereby reducing overhead. This operation is particularly useful for avoiding unnecessary memory copies or decoding of data.WriteBatch::Iteratoris not being directly used by TiKV. But it is still kept.