Skip to content

Commit

Permalink
Sanitize 8.10.tikv branch
Browse files Browse the repository at this point in the history
Signed-off-by: Yang Zhang <[email protected]>
  • Loading branch information
v01dstar committed Sep 18, 2024
1 parent 29219c2 commit d6bc9d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/sanity_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

- name: Fetch from upstream
run: |
git remote add upstream https://github.com/facebook/rocksdb.git && git fetch upstream
git remote add upstream https://github.com/tikv/rocksdb.git && git fetch upstream
- name: Where am I
run: |
Expand All @@ -37,6 +37,8 @@ jobs:

- name: Check format
run: VERBOSE_CHECK=1 make check-format
env:
FORMAT_UPSTREAM: upstream/8.10.tikv

- name: Compare buckify output
run: make check-buck-targets
Expand Down
6 changes: 1 addition & 5 deletions db/db_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1161,7 +1161,6 @@ class DelayFilterFactory : public CompactionFilterFactory {
};
} // anonymous namespace


static std::string CompressibleString(Random* rnd, int len) {
std::string r;
test::CompressibleString(rnd, 0.8, len, &r);
Expand Down Expand Up @@ -2686,6 +2685,7 @@ TEST_F(DBTest, PurgeInfoLogs) {
options.keep_log_file_num = 5;
options.create_if_missing = true;
options.env = env_;
env_->DeleteDir(dbname_);
for (int mode = 0; mode <= 1; mode++) {
if (mode == 1) {
options.db_log_dir = dbname_ + "_logs";
Expand Down Expand Up @@ -4339,7 +4339,6 @@ TEST_F(DBTest, ConcurrentMemtableNotSupported) {
ASSERT_NOK(db_->CreateColumnFamily(cf_options, "name", &handle));
}


TEST_F(DBTest, SanitizeNumThreads) {
for (int attempt = 0; attempt < 2; attempt++) {
const size_t kTotalTasks = 8;
Expand Down Expand Up @@ -5709,7 +5708,6 @@ TEST_F(DBTest, FileCreationRandomFailure) {
}
}


TEST_F(DBTest, DynamicMiscOptions) {
// Test max_sequential_skip_in_iterations
Options options;
Expand Down Expand Up @@ -7166,7 +7164,6 @@ TEST_F(DBTest, ReusePinnableSlice) {
1);
}


TEST_F(DBTest, DeletingOldWalAfterDrop) {
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
{{"Test:AllowFlushes", "DBImpl::BGWorkFlush"},
Expand Down Expand Up @@ -7291,7 +7288,6 @@ TEST_F(DBTest, LargeBlockSizeTest) {
ASSERT_NOK(TryReopenWithColumnFamilies({"default", "pikachu"}, options));
}


TEST_F(DBTest, CreationTimeOfOldestFile) {
const int kNumKeysPerFile = 32;
const int kNumLevelFiles = 2;
Expand Down

0 comments on commit d6bc9d9

Please sign in to comment.