Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: completely remove the deprecated field from the PD server config #8981

Merged
merged 2 commits into from
Jan 9, 2025
Merged

config: completely remove the deprecated field from the PD server config #8981

merged 2 commits into from
Jan 9, 2025
+7 −27

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jan 8, 2025

What problem does this PR solve?

Issue Number: Close #8980

What is changed and how does it work?

server/config: completely remove the deprecated field from the PD server config

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

From 7.1.1 to master:
image

master restart twice:
image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 8, 2025
@nolouch nolouch requested review from rleungx and bufferflies January 8, 2025 06:54
@nolouch nolouch force-pushed the fix-update-config-item branch from a3cd92a to b888156 Compare January 8, 2025 06:58
@nolouch nolouch force-pushed the fix-update-config-item branch from b888156 to 1204952 Compare January 8, 2025 07:08
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 8, 2025
@nolouch
Copy link
Contributor Author

nolouch commented Jan 8, 2025 •
edited
Loading

ptal @niubell

okJiang
okJiang reviewed Jan 8, 2025
View reviewed changes
server/config/config.go Outdated Show resolved Hide resolved
okJiang
okJiang reviewed Jan 8, 2025
View reviewed changes
server/config/config.go
c.FlowRoundByDigit = math.MaxInt8
}
case defineOld:
return errors.Errorf("config item %s and %s(deprecated) are conflict", newName, oldName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to report an error? How about print a warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to report the error, as the previous behavior also did.

@nolouch
Address Comments
9b497cd 
Signed-off-by: nolouch <[email protected]>
@nolouch nolouch force-pushed the fix-update-config-item branch from bffe5e4 to 9b497cd Compare January 8, 2025 08:44
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.39%. Comparing base (75cdec4) to head (9b497cd).
Report is 1100 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8981      +/-   ##
==========================================
+ Coverage   74.91%   76.39%   +1.47%     
==========================================
  Files         416      465      +49     
  Lines       42103    70539   +28436     
==========================================
+ Hits        31543    53888   +22345     
- Misses       7810    13314    +5504     
- Partials     2750     3337     +587
Flag Coverage Δ
unittests 76.39% <50.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 8, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-08 07:09:58.994131032 +0000 UTC m=+337542.282962739: ☑️ agreed by bufferflies.
  • 2025-01-08 09:52:15.310549178 +0000 UTC m=+347278.599380883: ☑️ agreed by rleungx.

@okJiang
Copy link
Member

okJiang commented Jan 9, 2025

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 9, 2025
@nolouch nolouch force-pushed the fix-update-config-item branch from 462d259 to 9b497cd Compare January 9, 2025 09:27
@ti-chi-bot ti-chi-bot bot merged commit 31a0ad6 into tikv:master Jan 9, 2025
37 of 39 checks passed
@nolouch nolouch deleted the fix-update-config-item branch January 9, 2025 09:41
@nolouch nolouch added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 9, 2025
@nolouch
Copy link
Contributor Author

nolouch commented Jan 9, 2025

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #8985.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 9, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jan 9, 2025
@ti-chi-bot @nolouch
config: completely remove the deprecated field from the PD server con…
5036cc2 
…fig (#8981) (#8985)

close #8980

server/config: completely remove the deprecated field from the PD server config

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang left review comments

@rleungx rleungx rleungx approved these changes

@bufferflies bufferflies bufferflies approved these changes

@niubell niubell niubell approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The flow-round-by-digit value will be changed after restart
6 participants
@nolouch @okJiang @ti-chi-bot @niubell @bufferflies @rleungx