test: make TestPreparingProgress stable #8966
Conversation
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: okJiang <[email protected]>
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8966 +/- ##
==========================================
- Coverage 76.34% 76.25% -0.10%
==========================================
Files 465 465
Lines 70537 70547 +10
==========================================
- Hits 53853 53796 -57
- Misses 13344 13394 +50
- Partials 3340 3357 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
tests/server/api/api_test.go
Outdated
| resp *http.Response | ||
| ) | ||
| testutil.Eventually(re, func() bool { | ||
| //nolint:bodyclose |
There was a problem hiding this comment.
why ignore this lint? you can place defer resp.Body.Close() into this function.
There was a problem hiding this comment.
It is closed in L1108 already
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: okJiang <[email protected]>
…o fix-TestPreparingProgress
|
/retest |
What problem does this PR solve?
Issue Number: Close #8693
What is changed and how does it work?
Check List
Tests
Release note