pd-heartbeat-bench: add default values #8569
Conversation
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8569 +/- ##
=======================================
Coverage 77.59% 77.60%
=======================================
Files 474 474
Lines 61891 61891
=======================================
+ Hits 48023 48029 +6
+ Misses 10327 10316 -11
- Partials 3541 3546 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
@lhy1024: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| epoch-update-ratio = 0.04 | ||
| space-update-ratio = 0.15 | ||
| flow-update-ratio = 0.35 |
There was a problem hiding this comment.
Can you explain why it should be 0.04/0.15/0.35?
There was a problem hiding this comment.
Copy from older configure
[LGTM Timeline notifier]Timeline:
|
|
PTAL @rleungx |
|
@okJiang: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Ref #7703
What is changed and how does it work?
After #7791, we remove the default config in the code to test a single variable.
But in some scenarios, we're more concerned with simulating a large cluster's status, so I put the default value back in the configuration file.
It is more friendly to guide the user to test.
Check List
Tests
Release note