-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs/resourcemanager: delete expire tokenSlot (#7344) #7349
mcs/resourcemanager: delete expire tokenSlot (#7344) #7349
Conversation
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ae13138
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #7349 +/- ##
===============================================
- Coverage 74.88% 74.81% -0.07%
===============================================
Files 410 410
Lines 41534 41544 +10
===============================================
- Hits 31104 31083 -21
- Misses 7704 7717 +13
- Partials 2726 2744 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is an automated cherry-pick of #7344
What problem does this PR solve?
If tidb/tiflash crash unexpectly or killed by signal which cannot be handled, there will be a useless slot, which will cause fillrate/burstlimit become less than expected for other alive ones.
So add a expire timeout(10min).
Issue Number: Close #7346
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note