grpc-sys: Upgrade bindgen to the latest version #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heftig
force-pushed
the
bindgen-upgrade
branch
4 times, most recently
from
ff24626 to
300d8f8
Compare
|
Thanks @heftig! |
|
I tried to compile and test the project on the new Apple M1, this patch seemed required to get it compile. |
BusyJay
reviewed
Dec 17, 2020
| @@ -298,6 +298,8 @@ fn bindgen_grpc(mut config: bindgen::Builder, file_path: &PathBuf) { | |||
| .clang_arg("-std=c++11") | |||
| .rustfmt_bindings(true) | |||
| .impl_debug(true) | |||
| .size_t_is_usize(true) | |||
| .disable_header_comment() | |||
There was a problem hiding this comment.
I suggest to keep it so people may not try to edit the generated file by hand.
There was a problem hiding this comment.
The header comment now contains the bindgen version number, making the output less stable.
Signed-off-by: Jan Alexander Steffens (heftig) <[email protected]>
Signed-off-by: Jan Alexander Steffens (heftig) <[email protected]>
heftig
force-pushed
the
bindgen-upgrade
branch
from
300d8f8 to
2264edc
Compare
BusyJay
approved these changes
Dec 18, 2020
hunterlxt
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #452 (comment).