Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: remove tilde requirements of protobuf #273

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

overvenus
Copy link
Member

So users can select protobuf version from "2.0.0" to "3.0.0".

Cc #272

@ice1000
Copy link
Contributor

ice1000 commented Jan 10, 2019

I suppose the CI is falling not because of the unstable tests. I saw new errors I've never seen.

@overvenus
Copy link
Member Author

There was a failure caused by rust-lang/rustup#1609, but now it is fixed.

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @brson

@rleungx rleungx added the Build Compilation, environment label Jan 14, 2019
@hicqu
Copy link
Contributor

hicqu commented Jan 16, 2019

LGTM

@overvenus overvenus merged commit fead789 into tikv:master Jan 16, 2019
@overvenus overvenus deleted the pb-caret-requirement branch January 16, 2019 10:11
overvenus added a commit to overvenus/grpc-rs that referenced this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Compilation, environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants