Add mixin options #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnuk
requested changes
Oct 26, 2022
| let content = `mixin ${dashPrefix(prefix)}${component}\n .${dashPrefix(prefix)}${component} ${component}\n`; | ||
| if(mixinOptions) { | ||
| content = `mixin ${dashPrefix(prefix)}${component}(options)\n` + | ||
| '\t-const opt = options || {};\n' + |
There was a problem hiding this comment.
Maybe you need to put spaces instead of tabulation
| const createMixin = (componentDirectory: string, component: string, prefix?: string, mixinOptions?: boolean): void => { | ||
| let content = `mixin ${dashPrefix(prefix)}${component}\n .${dashPrefix(prefix)}${component} ${component}\n`; | ||
| if(mixinOptions) { | ||
| content = `mixin ${dashPrefix(prefix)}${component}(options)\n` + |
There was a problem hiding this comment.
maybe you can extract to a function that returns content in order to prevent content mutation here
|
I'll close this PR because of inactivity. Please create another PR if you really need this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a component with options to mixin.
Working with Tikui, i find out that i often re-create the same code to add options to mixin.
That's why i propose to add the possibility to generate a component with options to mixin.
The related issue #62