fix: always inject dependencies from other subspaces #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a issue in
alwaysInjectDependenciesFromOtherSubspaces
logic.Before, we check the injected settings in the
package.json
to tell if a dependency is injected or not. However, inalwaysInjectDependenciesFromOtherSubspaces
case, user no need to set injected settings inpackage.json
for these dependencies. So this check logic is no longer accurate. It will lead a issue thatpnpm-sync.json
is not generated for these dependencies.So, now, we check the version representation in
pnpm-lock.yaml
to see if it is started withfile:
, if yes, then it is a injected dependency.