Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always inject dependencies from other subspaces #33

Merged
merged 4 commits into from
May 20, 2024

Conversation

g-chao
Copy link
Collaborator

@g-chao g-chao commented May 17, 2024

Summary

Fix a issue in alwaysInjectDependenciesFromOtherSubspaces logic.

Before, we check the injected settings in the package.json to tell if a dependency is injected or not. However, in alwaysInjectDependenciesFromOtherSubspaces case, user no need to set injected settings in package.json for these dependencies. So this check logic is no longer accurate. It will lead a issue that pnpm-sync.json is not generated for these dependencies.

So, now, we check the version representation in pnpm-lock.yaml to see if it is started with file:, if yes, then it is a injected dependency.

@g-chao g-chao merged commit 7e8b03d into main May 20, 2024
2 checks passed
@g-chao g-chao deleted the chao/fix-for-alwaysInjectDependenciesFromOtherSubspaces branch May 20, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants