wrong suggestions were given, remove algorithm that seeks for first pare... #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2014 20:34
…arenthesis. gocode already offers best suggestions base on offset.
…ide in GOROOT/bin and some configurations will have GOBIN in some directory. GOBIN is where commands are installed and may not be where go.exe is. The official go documentation may say that the go compiler resides in GOBIN, i do not know -- it's much better to assume that the go compiler resides in GOROOT/bin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOnpp was not giving me the suggestions properly in my go source code. It was always sending the offset 469 to gocode. The true offset is within a closure, which was a parameter of a function from the offset 469.
Since gocode already offers the best suggestions base on the provided offset, can we just remove the algorithm that seeks for the parenthesis?