imx9/px4io: Cleanups #776
Merged
imx9/px4io: Cleanups #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
px4_io_refining
branch
from
691f199
to
36bddac
Compare
|
Updated the patch to also fix the issue with debugassertion. The issue was in the end that nxsem_tickwait may also return other values than -ETIMEDOUT and OK. In such case, the DMA would have still be running when the DMA is re-started, causing debugassert in DEBUGASSERT(dmach != NULL && dmach->state == IMX9_DMA_CONFIGURED); This is now fixed by checking any possible error from the setup and stopping DMA channels in case of any errors. |
jlaitine
force-pushed
the
px4_io_refining
branch
from
f79f7cf
to
c4e03a7
Compare
- This occurs due to nxsem_tickwait returning also other error values than -ETIMEDOUT. Fix the issue by treating any error value as a timeout. - There is no need to clear the uart errors in _stop_dma, errors are cleared in uart irq Signed-off-by: Jukka Laitinen <[email protected]>
Check the return values from DMA operations and add a performance counter to detect if there are any DMA related errors. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
px4_io_refining
branch
from
c4e03a7
to
b405268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping tx dma in the short packet receive seems to fix the dma handle corruption issue. I have no idea why.