Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/arm64/imx9 Usb driver cache #298

Merged
merged 3 commits into from
Oct 3, 2024
Merged

arch/arm64/imx9 Usb driver cache #298

merged 3 commits into from
Oct 3, 2024

Conversation

joukkone
Copy link

@joukkone joukkone commented Oct 1, 2024

Modify cache clean/invalidate to get
mass-storage transfer work.

Summary

Impact

Testing

@joukkone joukkone requested a review from jlaitine October 1, 2024 12:13
@jlaitine
Copy link

jlaitine commented Oct 2, 2024

I am debugging the USB crashes with the re-based NuttX, so I will continue on this at the same

@jlaitine jlaitine force-pushed the usbcache branch 2 times, most recently from 1a4bba5 to 4501278 Compare October 2, 2024 10:19
@jlaitine
Copy link

jlaitine commented Oct 2, 2024

This is now tested to work; I will wait for upstream review before merging

joukkone and others added 3 commits October 3, 2024 09:32
…UGASSERTS

Correct some of the cache operations:

- EP0 request length was handled incorrectly
- Received data cache invalidate was exceeding the received buffer
- writedtd is also called with no data (EP0 ACK/NACK). Don't touch cache in that case.

Fix trip wire handling to conform with the IMX93 reference manual

Also add DEBUGASSERTS for future to check the validity of pointers and sizes

Co-authored-by: Jukka Laitinen <[email protected]>
…ep->maxpacket and CONFIG_CDCACM_BULKIN_REQLEN

The request length may not exceed CONFIG_CDCACM_BULKIN_REQLEN, otherwise buffer overflow will occur

This part is already changed in upstream with a slightly different patch

Signed-off-by: Jukka Laitinen <[email protected]>
… exceed CONFIG_PL2303_BULKIN_REQLEN

The request length may not exceed CONFIG_PL2303_BULKIN_REQLEN, otherwise buffer overflow will occur

Signed-off-by: Jukka Laitinen <[email protected]>
@jlaitine
Copy link

jlaitine commented Oct 3, 2024

Upstream merged, and this PR is update accordingly.

@jlaitine jlaitine merged commit 9070f68 into master Oct 3, 2024
11 checks passed
@jlaitine jlaitine deleted the usbcache branch October 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants