Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-imx8: Make the build pure #30

Open
wants to merge 1 commit into
base: wayland
Choose a base branch
from
Open

linux-imx8: Make the build pure #30

wants to merge 1 commit into from

Conversation

mikatammi
Copy link

Description of changes

Minor changes:

  • Add sha256 to make the build pure
  • Also change from builtins.fetchGit to fetchgit, this causes kernel source code to be fetched during build time, and not evaluation time.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

linux-imx8: Make the build pure
f13156c 
- Add sha256 to make the build pure
- Also change from builtins.fetchGit to fetchgit, this causes kernel
  source code to be fetched during build time, and not evaluation time.
vilvo
vilvo requested changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@vilvo vilvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - please create the PR here https://github.com/tiiuae/build-configurations/blob/main/overlays/bsp/kernel/linux-imx8/default.nix as we are in the process of replacing this wayland-branch with more modular build-configuration that can use upstream directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilvo vilvo vilvo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikatammi @vilvo