Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWW: Add control panel, log out, and lock buttons, restyling #855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kajusnau
Copy link
Contributor

@kajusnau kajusnau commented Oct 18, 2024

Description of changes

  1. Added Control Panel and Power Menu Buttons:
    • New control panel button (called "Settings" now) added to the quick settings widget.
    • New log out and lock buttons added into the power menu widget.
    • More detailed design and composition currently in progress by UI designer.

image (1) image (2)

  1. Removed Shutdown and Log Out Apps From Launcher:

    • The shutdown and log out applications have been removed from the launcher to reduce redundancy.
  2. Added Missing nm-applet UI Elements:

    • Missing UI elements for the nm-applet have been added.
  3. Moved GTK Lock Style Definition To Its Own File:

    • This PR proposes moving all future style definitions to modules/desktop/graphics/styles for easier maintainability of the styles and the components that use them.
    • Other styles that could be moved include: gtkgreet, drawer, and ewwbar.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    Lenovo X1
  • Is this a new feature
    • List the test steps to verify:
      Can be tested on Lenovo X1 following usual installation or nixos-rebuild ... switch
  • If it is an improvement how does it impact existing functionality?
    Listed in the description above.

- Added control panel button in quick settings widget
- Added log out and lock buttons in power menu widget
- Removed shutdown and log out apps from launcher
- Added missing nm-applet UI elements
- Moved gtklock style definition to its own file

Signed-off-by: Kajus Naujokaitis <[email protected]>
@kajusnau kajusnau temporarily deployed to internal-build-workflow October 18, 2024 11:50 — with GitHub Actions Inactive
@kajusnau kajusnau added the Needs Testing CI Team to pre-verify label Oct 18, 2024
@kajusnau kajusnau self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing CI Team to pre-verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant