Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify audio-ctrl helper package #854

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josa41
Copy link
Contributor

@josa41 josa41 commented Oct 18, 2024

Description of changes

Minor change to simplify audio-ctrl helper script
The script is used by eww-bar and desktop for hardware volume buttons

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@josa41 josa41 temporarily deployed to internal-build-workflow October 18, 2024 08:25 — with GitHub Actions Inactive
@josa41 josa41 added the Needs Testing CI Team to pre-verify label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing CI Team to pre-verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants