Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tools invocation for xdg scripts #853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

unbel13ver
Copy link
Contributor

@unbel13ver unbel13ver commented Oct 17, 2024

The invocations of tools are reworked in a Nix-friendly way.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

In gui-vm, double-click on any .pdf file, it should open as usual.

  • List all targets that this applies to: x86 Laptop
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    It does not impact existing functionality but prevents possible future issues.

@unbel13ver unbel13ver temporarily deployed to internal-build-workflow October 17, 2024 13:48 — with GitHub Actions Inactive
@unbel13ver unbel13ver marked this pull request as ready for review October 17, 2024 13:49
@@ -35,16 +35,16 @@ let
xdgOpenFile = pkgs.writeShellScriptBin "xdgopenfile" ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to writeShellApplication, then the packages are passed as inputs and you don't need to use app path, just binary name e.g. 'realpath' vs pkgs.coreutils/bin/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants