Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ms365 url fetcher script to update proxy whitelist dynamically #846

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ms365 url fetcher script to update proxy whitelist dynamically #846

wants to merge 1 commit into from
+288 −1,060

Conversation

enesoztrk
Copy link
Contributor

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@enesoztrk enesoztrk temporarily deployed to internal-build-workflow October 15, 2024 13:35 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow October 15, 2024 13:43 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow October 17, 2024 10:27 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow October 17, 2024 12:59 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow October 17, 2024 13:30 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow October 17, 2024 13:32 — with GitHub Actions Inactive
mbssrc
mbssrc reviewed Oct 18, 2024
View reviewed changes
modules/reference/services/proxy-server/3proxy-config.nix
];
# Define a new user with a specific username
users.users.${proxyUserName} = {
isNormalUser = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a system user?

@tiiuae tiiuae deleted a comment Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbssrc mbssrc mbssrc left review comments

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

@humaidq-tii humaidq-tii Awaiting requested review from humaidq-tii

@milva-unikie milva-unikie Awaiting requested review from milva-unikie

@barnabakos barnabakos Awaiting requested review from barnabakos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enesoztrk @mbssrc