Add basic testing for coldstart and scaling #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Tserepov-Savolainen <[email protected]>
Signed-off-by: Aleksandr Tserepov-Savolainen <[email protected]>
cazfi
reviewed
Sep 18, 2024
| # Azure Function (verify-signature) URL | ||
| URL = "https://ghaf-devenv-microsign-aleksandrtserepo-app.azurewebsites.net/api/verify-signature" | ||
| #URL = "http://localhost:7071/api/VerifySignature" | ||
| #URL = "https://ghaf-devenv-signverify.azurewebsites.net/api/verifysignature" |
There was a problem hiding this comment.
Do these commented out lines serve any purpose? They're ok for me, if one expects to regularly enable the lines e.g. when debugging.
There was a problem hiding this comment.
Not really, just a leftover from debugging session. Will clean. Thanks!
| print(f"Received 503 from {url}. Retrying... (retry count: {retry_count + 1})") | ||
| retry_count += 1 | ||
| time.sleep(sleep_interval) | ||
| else: |
There was a problem hiding this comment.
Should result code 1(?) indicating that signature verification process seems to work, but signature is wrong, be handled differently from a complete failure?
There was a problem hiding this comment.
Good point. The thing was that we were trying to catch 503 here as that was the biggest concern (intermittent 503 most likely due to cold start) and I didn't pay too much attention at the other details. Will fix. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.