Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of microsign FunctionApp #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alextserepov
Copy link
Collaborator

@alextserepov alextserepov commented Sep 9, 2024

Initial Commit: Microsign Service

This version enables anonymous signature verification only. Access to Key Vault functionality is managed through Key Vault access policies via managed identity. Only the permission for signature verification should be granted.

Signed-off-by: Aleksandr Tserepov-Savolainen <[email protected]>
@alextserepov alextserepov requested a review from a team September 9, 2024 20:23
@alextserepov alextserepov self-assigned this Sep 9, 2024
@henrirosten
Copy link

Consider fixing relevant pylint errors (you decide if they are relevant or not):

❯ pylint ~/projects/ci-yubi/microsign/function_app.py
************* Module function_app
ci-yubi/microsign/function_app.py:15:50: C0303: Trailing whitespace (trailing-whitespace)
ci-yubi/microsign/function_app.py:16:91: C0303: Trailing whitespace (trailing-whitespace)
ci-yubi/microsign/function_app.py:40:0: C0301: Line too long (103/100) (line-too-long)
ci-yubi/microsign/function_app.py:48:0: C0301: Line too long (109/100) (line-too-long)
ci-yubi/microsign/function_app.py:1:0: C0114: Missing module docstring (missing-module-docstring)
ci-yubi/microsign/function_app.py:17:0: C0116: Missing function or method docstring (missing-function-docstring)
ci-yubi/microsign/function_app.py:45:11: W0718: Catching too general exception Exception (broad-exception-caught)
ci-yubi/microsign/function_app.py:25:8: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
ci-yubi/microsign/function_app.py:26:8: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
ci-yubi/microsign/function_app.py:36:8: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
ci-yubi/microsign/function_app.py:46:8: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
ci-yubi/microsign/function_app.py:6:0: C0411: standard import "json" should be placed before third party imports "azure.functions", "azure.identity.DefaultAzureCredential", "azure.keyvault.keys.KeyClient", "azure.keyvault.keys.crypto.CryptographyClient" (wrong-import-order)
ci-yubi/microsign/function_app.py:7:0: C0411: standard import "base64" should be placed before third party imports "azure.functions", "azure.identity.DefaultAzureCredential", "azure.keyvault.keys.KeyClient", "azure.keyvault.keys.crypto.CryptographyClient" (wrong-import-order)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants