Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for .ts routes file #717

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Allow for .ts routes file #717

wants to merge 1 commit into from

Conversation

Stnaire
Copy link

@Stnaire Stnaire commented Feb 24, 2024

Small changes to allow the generate command to output .ts files.

@bakerkretzmar bakerkretzmar self-assigned this Feb 24, 2024
@bakerkretzmar
Copy link
Collaborator

Thanks! This makes sense but it needs a bit more work. Just thinking out loud, I'm happy to make these changes.

  • Need to add/update tests.
  • Need to check a bit more carefully in the first path normalization because if they pass a .d.ts filename I think that'll make it through and be used by Ziggy to generate the file, which I don't think we want.
  • I think the generated file may contain type errors, we might need something like this but I'm not sure and I don't know if there would be other side effects:
declare global {
    var Ziggy: Config;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants