Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes markdown rendering on email digests #613

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fixes markdown rendering on email digests #613

merged 3 commits into from
Dec 3, 2024

Conversation

gcavanunez
Copy link
Contributor

@gcavanunez gcavanunez commented Dec 2, 2024 •
edited
Loading

Highlights

  • removes all white spaces from email templates that opt for markdown rendering
  • tweaks the unsub look and feels

Notes

Feels a lil odd to say Onramp so much in the email, but also kind of like it, what ya think?

Email Screenshots

image

@gcavanunez gcavanunez marked this pull request as ready for review December 2, 2024 22:53
MarcyLina
MarcyLina reviewed Dec 3, 2024
View reviewed changes
resources/views/emails/resource-digest.blade.php Outdated

### Your friends at {{ config('app.name') }}
### Your friends at {{ config('app.name') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right about using the word Onramp so much. What do you think of this saying: "Your friends at Tighten" or something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!

@gcavanunez gcavanunez merged commit b7cfd69 into main Dec 3, 2024
2 checks passed
@gcavanunez gcavanunez deleted the gc/fix-email-formatting branch December 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcyLina MarcyLina MarcyLina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcavanunez @MarcyLina