Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-10623] Make apiserver ports configurable to avoid conflicts on EKS #3806

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lucastigera
Copy link

@lucastigera lucastigera commented Mar 7, 2025

Description

The current implementation includes the following changes:

  • Added a new Ports attribute to the APIServerDeploymentContainer.
  • Updated the APIServer CRD to include the new Ports attribute.
  • Modified the components.go file to incorporate logic for considering this attribute in the override logic.
  • Replaced hardcoded constants for the Readiness and Liveness ports in the ApiServer, QueryServer, and L7AdmissionController containers with default values or overridden values.
  • In the Services configurations, use the PortName instead of the number, if specified.

Related PR

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@lucastigera lucastigera requested a review from a team as a code owner March 7, 2025 17:02
@marvin-tigera marvin-tigera added this to the v1.38.0 milestone Mar 7, 2025
@lucastigera lucastigera marked this pull request as draft March 7, 2025 17:03
@lucastigera lucastigera marked this pull request as ready for review March 10, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants