-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow creating a new operator based off a previous operator #3699
base: master
Are you sure you want to change the base?
Conversation
4d31d88
to
1073316
Compare
1073316
to
8caa076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of feedback. I would also request a small README.md with usage examples just to get people up to speed more quickly on how to use the tool and where/when/why.
37a302c
to
b2d2340
Compare
b2d2340
to
6daae8e
Compare
- support custom registry - fixes from validating - modify config files and preserve comments - update examples in README
6daae8e
to
5c84574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, no other feedback
Description
Allow building an operator image using a previous hashrelease/release as base and changing a few components.
For PR author
If changing pkg/apis/, runmake gen-files
If changing versions, runmake gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.