Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow creating a new operator based off a previous operator #3699

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

radTuti
Copy link
Contributor

@radTuti radTuti commented Jan 14, 2025

Description

Allow building an operator image using a previous hashrelease/release as base and changing a few components.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Contributor

@danudey danudey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of feedback. I would also request a small README.md with usage examples just to get people up to speed more quickly on how to use the tool and where/when/why.

hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Show resolved Hide resolved
hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Outdated Show resolved Hide resolved
hack/release-from/action.go Show resolved Hide resolved
hack/release-from/utils.go Show resolved Hide resolved
- support custom registry
- fixes from validating
- modify config files and preserve comments
- update examples in README
Copy link
Contributor

@danudey danudey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no other feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants