Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serviceaccount list to network-admin and user-ui #3687

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add serviceaccount list to network-admin and user-ui #3687

merged 2 commits into from
Jan 10, 2025

Conversation

dimitri-nicolo
Copy link
Contributor

@dimitri-nicolo dimitri-nicolo commented Jan 9, 2025 •
edited
Loading

Description

Adds serviceaccounts list RBAC to tigera-network-admin and tigera-ui-user

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@dimitri-nicolo dimitri-nicolo requested a review from a team as a code owner January 9, 2025 18:58
@marvin-tigera marvin-tigera added this to the v1.38.0 milestone Jan 9, 2025
@dimitri-nicolo dimitri-nicolo force-pushed the dimitri-add-serviceaccount-list-network-admin branch from fc70e9f to 6e59535 Compare January 9, 2025 18:59
rene-dekker
rene-dekker approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimitri-nicolo dimitri-nicolo force-pushed the dimitri-add-serviceaccount-list-network-admin branch from 6e59535 to bbbebab Compare January 9, 2025 21:43
@dimitri-nicolo
Copy link
Contributor Author

@rene-dekker Could you please merge? ty!

@rene-dekker rene-dekker merged commit c792fcc into tigera:master Jan 10, 2025
5 checks passed
@dimitri-nicolo dimitri-nicolo deleted the dimitri-add-serviceaccount-list-network-admin branch January 10, 2025 21:00
ti-afra pushed a commit to ti-afra/operator that referenced this pull request Jan 14, 2025
@dimitri-nicolo @ti-afra
Add serviceaccount list to network-admin and user-ui (tigera#3687)
1011972 
* Add serviceaccount list to network-admin and user-ui

* Fix dirty felixconfigurations.yaml
marvin-tigera added a commit that referenced this pull request Jan 14, 2025
@marvin-tigera
Merge pull request #3700 from ti-afra/update-clusterroles
562ec99 
Add serviceaccount list to network-admin and user-ui (#3687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene-dekker rene-dekker rene-dekker approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dimitri-nicolo @rene-dekker @marvin-tigera