Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Host Numeric rule from coreruleset #3552

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

radixo
Copy link
Contributor

@radixo radixo commented Oct 17, 2024

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@radixo radixo force-pushed the coreruleset-remove-numeric-host branch from 25a0ec8 to 6644d07 Compare October 17, 2024 15:34
@radixo radixo force-pushed the coreruleset-remove-numeric-host branch from 6644d07 to c8ed7f5 Compare October 17, 2024 15:36
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker
Copy link
Member

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit 8e2a56d into tigera:master Oct 17, 2024
5 checks passed
@radixo radixo deleted the coreruleset-remove-numeric-host branch October 17, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants