Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append TIGERA_TPROXY_ENABLED to per host envoy #3518

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

radixo
Copy link
Contributor

@radixo radixo commented Sep 24, 2024

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electricjesus electricjesus merged commit 57b61bc into tigera:master Sep 25, 2024
5 checks passed
electricjesus added a commit to electricjesus/operator that referenced this pull request Sep 27, 2024
* Append TIGERA_TPROXY_ENABLED to per host envoy

* Apply suggestions from code review

---------

Co-authored-by: Seth Malaki <[email protected]>
radixo added a commit to radixo/operator that referenced this pull request Sep 30, 2024
* Append TIGERA_TPROXY_ENABLED to per host envoy

* Apply suggestions from code review

---------

Co-authored-by: Seth Malaki <[email protected]>
radixo added a commit to radixo/operator that referenced this pull request Sep 30, 2024
* Append TIGERA_TPROXY_ENABLED to per host envoy

* Apply suggestions from code review

---------

Co-authored-by: Seth Malaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants