Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes enovyproxy-envoy, sidecar images for envoy #3514

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Removes enovyproxy-envoy, sidecar images for envoy #3514

merged 2 commits into from
Sep 20, 2024

Conversation

radixo
Copy link
Contributor

@radixo radixo commented Sep 20, 2024

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@radixo radixo requested a review from a team as a code owner September 20, 2024 20:02
@marvin-tigera marvin-tigera added this to the v1.37.0 milestone Sep 20, 2024
tmjd
tmjd approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit dcd1198 into tigera:master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radixo @tmjd @marvin-tigera