Calico apiserver improvements #3481
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tamas-Biro1
force-pushed
the
calico-apiserver-improvements
branch
2 times, most recently
from
7bc4d24
to
4ee9d6e
Compare
Tamas-Biro1
force-pushed
the
calico-apiserver-improvements
branch
from
4ee9d6e
to
57ec0f3
Compare
tmjd
reviewed
Aug 29, 2024
| @@ -87,6 +87,9 @@ type APIServerDeploymentContainer struct { | |||
| // If used in conjunction with the deprecated ComponentResources, then this value takes precedence. | |||
| // +optional | |||
| Resources *v1.ResourceRequirements `json:"resources,omitempty"` | |||
|
|
|||
| // +optional | |||
| Lifecycle *v1.Lifecycle `json:"lifecycle,omitempty" protobuf:"bytes,12,opt,name=lifecycle"` | |||
There was a problem hiding this comment.
I'd like to hear the use case for adding this. (I hadn't heard of Lifecycle before but looking at the K8s API reference I don't understand what its use case would be for the apiserver.)
| // The deployment strategy to use to replace existing pods with new ones. | ||
| // +optional | ||
| // +patchStrategy=retainKeys | ||
| Strategy *APIServerDeploymentStrategy `json:"strategy,omitempty" patchStrategy:"retainKeys" protobuf:"bytes,4,opt,name=strategy"` |
There was a problem hiding this comment.
I'd want to hear what the use case is that we need to add this override for the apiserver. In other words why would someone need to change the Strategy?
| // +optional | ||
| // +kubebuilder:validation:Minimum=0 | ||
| // +kubebuilder:validation:Maximum=2147483647 | ||
| Replicas *int32 `json:"replicas,omitempty"` |
There was a problem hiding this comment.
The replicas for the apiserver can already be controlled through the Installation resource with the controlPlaneReplicas field.
I'm not saying this wouldn't be useful but just wanted to point out it is possible to change the number of replicas.
Tamas-Biro1
force-pushed
the
calico-apiserver-improvements
branch
from
57ec0f3
to
2f8a13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.