Disable CGO when build operator #3229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset disables CGO when building operator binary for all supported architectures. We shelved FIPS support so bringing back tls module from Go stdlib reenabled TLS 1.3 support.
hjiawei
commented
Mar 8, 2024
Comment on lines
-44
to
-46
| # The exec form of ENTRYPOINT does not invoke a command shell. | ||
| # This means that normal shell processing does not happen, so will not | ||
| # do variable substitution. Using this form instead of passing $OPERATOR. |
There was a problem hiding this comment.
This comment doesn't seem to apply any more so removed.
|
We are removing FIPS for enterprise. I still need to find out the exact requirements for open source. I think that the operator will probably continue to be able to install FIPS for open source. What I think we may want to consider is disabling CGO/boringcrypto by default but continue to allow users to build the image with a FIPS=true flag. |
|
issue: #3461
Can we disable CGO/boringcrypto by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset disables CGO when building operator binary for all supported architectures. We shelved FIPS support so bringing back tls module from Go stdlib reenabled TLS 1.3 support.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.