Clean up Linseed elastic users for non-existent tenants #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Export Elastic mock functions and structs for use more generally -Introduce new test suite for users controller unit tests
Josh-Tigera
force-pushed
the
josh.users-cleanup
branch
from
cfcd487 to
6d8863c
Compare
-Incorporate new expectation of a "clusterID" to be used in ES username creation -Add unit tests for ES username formatting and role generation
Josh-Tigera
commented
Oct 18, 2023
pkg/controller/logstorage/esuserscleanup/ususerscleanup_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/logstorage/esuserscleanup/ususerscleanup_controller.go
Outdated
Show resolved
Hide resolved
| err = r.client.Get(ctx, clusterIDConfigMapKey, &clusterIDConfigMap) | ||
| if err != nil { | ||
| r.status.SetDegraded(operatorv1.ResourceReadError, fmt.Sprintf("Waiting for ConfigMap %s/%s to be available", clusterIDConfigMapKey.Namespace, clusterIDConfigMapKey.Name), | ||
| nil, reqLogger) |
There was a problem hiding this comment.
Should we pass err instead of nil here?
caseydavenport
approved these changes
Oct 20, 2023
Josh-Tigera
added a commit
to Josh-Tigera/operator
that referenced
this pull request
Oct 23, 2023
Clean up Linseed elastic users for non-existent tenants
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Export Elastic mock functions and structs for use more generally
-Introduce new test suite for users controller unit tests
Description
For PR author
- [ ] If changing pkg/apis/, runmake gen-files- [ ] If changing versions, runmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.