Add support for Windows hostprocess containers #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutinhop
force-pushed
the
pedro-win-hpc-1
branch
4 times, most recently
from
1978e51
to
558c496
Compare
coutinhop
force-pushed
the
pedro-win-hpc-1
branch
2 times, most recently
from
b67c768
to
6c46fea
Compare
3 tasks
coutinhop
force-pushed
the
pedro-win-hpc-1
branch
from
6f37cd3
to
4f3d0c5
Compare
- Add windows calico-node daemonset with hostprocess containers. - Add windows kube-proxy daemonset using sig-windows hostprocess container image. - Add optional (required only for windows) fields KUBERNETES_SERVICE_CIDR and KUBERNETES_DNS_SERVERS to kubernetes-services-endpoint configmap. Manually tested with a clean installation and VXLAN setup and images from projectcalico/calico#7857. Still a work in progress. Pending: - Tests for windows calico-node rendering (pkg/render/windows_test.go) - Possibly make CNI BIN and CONF dirs configurable for Windows in the installation - Possibly roll out our own kube-proxy image instead of using the one from sig-windows - Possibly adding an initContainer to clean up "old" style non-HPC Calico installations before proceeding
…rd v1.7+). Don't render windows daemonset if disabled in installation resource.
…template). Add Calico Windows render default config UT case. Add VXLANMACPrefix to WindowsConfig. Make getCalicoIPAM() an isolated function like buildHostLocalIPAM() so they both behave similarly.
Add degraded message for unsupported encapsulation on windows to core_controller. Add explicti MTU, Calico CNI on EKS and AmazonVPC CNI tests to windows_test.go.
…d fix file paths to make them compatible with v1.6
…etworks plugin to node clusterrole when on EE. Fix CNI paths and template in order for HPC to work with containerd v1.6.
coutinhop
force-pushed
the
pedro-win-hpc-1
branch
from
2cb7af7
to
5f8441f
Compare
caseydavenport
requested changes
Sep 15, 2023
- Move validation out of windows_controller - Remove unnecessary env vars from windows node containers - Test adjustments
caseydavenport
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Windows hostprocess containers
(rendered only if enabled by setting WindowsDataplane to 'HNS' in the Installation).
Manually tested with a clean installation and VXLAN setup and images
from projectcalico/calico#7857.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.