Postpone policy recommendation scope watches until apiserver is up an… #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
reviewed
Jul 5, 2023
| @@ -65,6 +65,7 @@ func Add(mgr manager.Manager, opts options.AddOptions) error { | |||
| } | |||
| licenseAPIReady := &utils.ReadyFlag{} | |||
| tierWatchReady := &utils.ReadyFlag{} | |||
| policyRecScopeWatchReady := &utils.ReadyFlag{} | |||
There was a problem hiding this comment.
It seems like we should check this ready flag (like we do with the license and tier ones) before fetching the PolicyRecommendationScopes in the Reconcile.
There was a problem hiding this comment.
Yep, that's an important part of this - prevents us sending unnecessary requests to the apiserver and ensures we're using our cache to satisfy client queries.
rene-dekker
added a commit
that referenced
this pull request
Jul 7, 2023
* Postpone policy recommendation scope watches until apiserver is up and running * Block the policy recommendation controller if the apiserver watch is not established yet * Mark readyFlag in unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects: EV-3878 EV-3861