Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAF: CoreRuleset update to v3.3.4 #2709

Closed
wants to merge 6 commits into from

Conversation

electricjesus
Copy link
Member

@electricjesus electricjesus commented Jun 28, 2023

Description

Fix: use appropriate CRS rules, setup files and engine (in dikastes) versions together:

  • fix CRS version to v3.3.4
  • Use correct modsecdefault.conf version that should go with it
  • Don't set SecRuleEngine is now DetectionOnly by default to minimize post-install disruption

This should reduce false detections due to configuration mismatch(es)

Feat: updater Make target

  • workflow for keeping CRS files up-to-date
  • replace gen.go strategy with embed.FS
  • not yet connected to CI dirty checks so updates aren't detected automatically

To use:

make generate-crs

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants