Clean up

tigera · Sep 12, 2023 · 3dc8f90 · 3dc8f90
1 parent e3426ed
commit 3dc8f90
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 19 deletions.
diff --git a/pkg/tls/certificatemanagement/certificatebundle.go b/pkg/tls/certificatemanagement/certificatebundle.go
@@ -221,15 +221,6 @@ func (c *certificate) GetIssuer() CertificateInterface {
 	return c.issuer
 }
 
-func (c *certificate) GetCommonName() string {
-	cert, err := ParseCertificate(c.pem)
-	if err != nil {
-		return ""
-	}
-
-	return cert.Issuer.CommonName
-}
-
 // certFiles is copied from the x509 package, but re-ordered, since in practice this should run containerized
 // and stop at the first entry. More at: https://go.dev/src/crypto/x509/root_linux.go for the source.
 //

diff --git a/pkg/tls/certificatemanagement/interface.go b/pkg/tls/certificatemanagement/interface.go
@@ -55,7 +55,6 @@ type CertificateInterface interface {
 	GetCertificatePEM() []byte
 	GetName() string
 	GetNamespace() string
-	GetCommonName() string
 }
 
 // TrustedBundle is used to create a trusted certificate bundle of the CertificateManager CA and 0 or more Certificates.

diff --git a/pkg/tls/certificatemanagement/keypair.go b/pkg/tls/certificatemanagement/keypair.go
@@ -158,15 +158,6 @@ func (k *KeyPair) GetIssuer() CertificateInterface {
 	return k.Issuer
 }
 
-func (k *KeyPair) GetCommonName() string {
-	cert, err := ParseCertificate(k.CertificatePEM)
-	if err != nil {
-		return ""
-	}
-
-	return cert.Issuer.CommonName
-}
-
 // NewKeyPair returns a KeyPair, which wraps a Secret object that contains a private key and a certificate. Whether certificate
 // management is configured or not, KeyPair returns the right InitContainer, Volumemount or Volume (when applicable).
 func NewKeyPair(secret *corev1.Secret, dnsNames []string, clusterDomain string) KeyPairInterface {