Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation notice to FIPS in OSS (enterprise page is gone) #1844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaaaaaaalex
Copy link
Contributor

@aaaaaaaalex aaaaaaaalex commented Jan 17, 2025

CORE-10911

Product Version(s):
OSS next

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@aaaaaaaalex aaaaaaaalex requested a review from a team as a code owner January 17, 2025 11:57
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for calico-docs-preview-next failed. Why did it fail? →

Name Link
🔨 Latest commit 37a185c
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/678a459b060c6e0008481efd

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 37a185c
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/678a459bec1b600008a0ce1e
😎 Deploy Preview https://deploy-preview-1844--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 17 (🔴 down 8 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen
Copy link
Collaborator

Thanks @aaaaaaaalex. I know we deprecated and removed FIPS support in CE and CC. Last I remember we were keeping this in OSS because it might work, even if we don't support it. My memory may be off though.

Does this change stem from code changes that will kill this function entirely?

@aaaaaaaalex
Copy link
Contributor Author

@ctauchen , while I haven't ripped out any FIPS code, I have been working on a FIPS-adjacent customer issue and was advised to add this notice.

Last I remember we were keeping this in OSS because it might work, even if we don't support it.

I'll CC @fasaxc and @matthewdupre here - I think we were of the belief that this FIPS documentation was left in by accident. Since I haven't killed off any FIPS functionality, I would imagine your reasoning still holds true. Do we want to carry on with this change now?

@ctauchen
Copy link
Collaborator

Ok, thanks for that context. If we do want this gone, we might go ahead and add the deprecation notice to 3.29 with scheduled removal in 3.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants