Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct maxBlocksPerHost default #1826

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

caseydavenport
Copy link
Member

Fixes projectcalico/calico#9462

While the API structure itself defaults to 0, the code interprets 0 to
mean "20" . . .

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@caseydavenport caseydavenport requested a review from a team as a code owner December 30, 2024 17:07
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit e56a6c0
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/6772d3492c5c3e000886b505
😎 Deploy Preview https://deploy-preview-1826--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit e56a6c0
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/6772d3490a013b0008269521
😎 Deploy Preview https://deploy-preview-1826--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🔴 down 4 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@caseydavenport
Copy link
Member Author

@ctauchen

@ctauchen
Copy link
Collaborator

LGTM.

@caseydavenport caseydavenport merged commit c251517 into tigera:main Dec 31, 2024
10 checks passed
@caseydavenport caseydavenport deleted the casey-fix-max-blocks branch December 31, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for IPAMConfiguration MaxBlocksPerHost has incorrect default value
3 participants